Re: Review Request: Fixed compiler warnings.

"Robert Mathias Marmorstein" <[email protected]> Sat, 03 Mar 2012 15:06:52 -0000
Newsgroups gmane.comp.kde.devel.koffice
Message-ID <[email protected]> 
--===============7695844642010259559==
Content-Type: multipart/alternative;
	boundary="===============8357900496182007972=="

--===============8357900496182007972==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable



> On March 3, 2012, 3:05 p.m., Robert Mathias Marmorstein wrote:
> > Ship It!

I went ahead and applied this patch.  Thanks for the submission!


- Robert Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103996/#review11111
-----------------------------------------------------------


On Feb. 22, 2012, 5 a.m., Richie Noble wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103996/
> -----------------------------------------------------------
> =

> (Updated Feb. 22, 2012, 5 a.m.)
> =

> =

> Review request for KOffice, Robert Mathias Marmorstein and Thomas Zander.
> =

> =

> Description
> -------
> =

> Fixed a few simple compiler warnings in the koffice flake and kotext libr=
aries. These mostly involved removing superfluous lines of code that were p=
robably needed in earlier versions of koffice but are unused now. The bigge=
st change was made in libs/kotext/styles/KParagraphStyle.cpp where the remo=
ved lines were part of a section that was commented out to improve compatib=
ility with other office suites, specifically OpenOffice.
> =

> =

> Diffs
> -----
> =

>   libs/flake/KRTree.h 6b29017 =

>   libs/kotext/KTextBlockBorderData.cpp 58339dd =

>   libs/kotext/styles/KParagraphStyle.cpp 5377b04 =

> =

> Diff: http://git.reviewboard.kde.org/r/103996/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Richie Noble
> =

>


--===============8357900496182007972==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/103996/">http://git.revie=
wboard.kde.org/r/103996/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; padd=
ing-left: 10px;">
 <p style=3D"margin-top: 0;">On March 3rd, 2012, 3:05 p.m., <b>Robert Mathi=
as Marmorstein</b> wrote:</p>
 <blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
  <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!<=
/pre>
 </blockquote>







</blockquote>

<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spac=
e: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I went ahea=
d and applied this patch.  Thanks for the submission!</pre>
<br />








<p>- Robert Mathias</p>


<br />
<p>On February 22nd, 2012, 5 a.m., Richie Noble wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KOffice, Robert Mathias Marmorstein and Thomas Zand=
er.</div>
<div>By Richie Noble.</div>


<p style=3D"color: grey;"><i>Updated Feb. 22, 2012, 5 a.m.</i></p>






<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
 <table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Fixed a few simple compiler warnings in the koffice flake an=
d kotext libraries. These mostly involved removing superfluous lines of cod=
e that were probably needed in earlier versions of koffice but are unused n=
ow. The biggest change was made in libs/kotext/styles/KParagraphStyle.cpp w=
here the removed lines were part of a section that was commented out to imp=
rove compatibility with other office suites, specifically OpenOffice.</pre>
  </td>
 </tr>
</table>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>libs/flake/KRTree.h <span style=3D"color: grey">(6b29017)</span></li>

 <li>libs/kotext/KTextBlockBorderData.cpp <span style=3D"color: grey">(5833=
9dd)</span></li>

 <li>libs/kotext/styles/KParagraphStyle.cpp <span style=3D"color: grey">(53=
77b04)</span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/103996/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============8357900496182007972==--

--===============7695844642010259559==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============7695844642010259559==--