Review Request: Fix confusing CMake messages

"Robert Mathias Marmorstein" <[email protected]> Thu, 08 Mar 2012 05:26:30 -0000
Newsgroups gmane.comp.kde.devel.koffice
Message-ID <[email protected]> 
--===============3761044483634279272==
Content-Type: multipart/alternative;
	boundary="===============5284472684792394123=="

--===============5284472684792394123==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104191/
-----------------------------------------------------------

Review request for KOffice.


Description
-------

This fixes a problem with how CMake reports a missing libwps.  I think this=
 is a bug I introduced myself when upgrading things to the new wpg librarie=
s.  Essentially, instead of reporting that libwps was missing, it was repor=
ting that the libwpg stream library was missing.  While it's true that libw=
ps IS the libwpg stream library, most distributions package it as libwps.  =


Additionally, the cmake module was not correctly checking the cache to see =
whether libwps had been installed.  So if someone ran cmake, got the error,=
 and then installed wps, the error would come up even if the problem had be=
en corrected. =


This patch fixes both glitches.


Diffs
-----

  cmake/modules/FindWPG.cmake cb12f91 =

  filters/artwork/CMakeLists.txt b949dd9 =


Diff: http://git.reviewboard.kde.org/r/104191/diff/


Testing
-------

KOffice builds and runs both with and without libwps and CMake correctly de=
tects whether libwps is present.


Thanks,

Robert Mathias Marmorstein


--===============5284472684792394123==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/104191/">http://git.revie=
wboard.kde.org/r/104191/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>







<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
 <table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">This fixes a problem with how CMake reports a missing libwps=
.  I think this is a bug I introduced myself when upgrading things to the n=
ew wpg libraries.  Essentially, instead of reporting that libwps was missin=
g, it was reporting that the libwpg stream library was missing.  While it&#=
39;s true that libwps IS the libwpg stream library, most distributions pack=
age it as libwps.  =


Additionally, the cmake module was not correctly checking the cache to see =
whether libwps had been installed.  So if someone ran cmake, got the error,=
 and then installed wps, the error would come up even if the problem had be=
en corrected. =


This patch fixes both glitches.</pre>
  </td>
 </tr>
</table>


<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">KOffice builds and runs both with and without libwps and CMa=
ke correctly detects whether libwps is present.</pre>
  </td>
 </tr>
</table>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindWPG.cmake <span style=3D"color: grey">(cb12f91)</spa=
n></li>

 <li>filters/artwork/CMakeLists.txt <span style=3D"color: grey">(b949dd9)</=
span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/104191/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============5284472684792394123==--

--===============3761044483634279272==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============3761044483634279272==--