Re: Review Request: Change dynamic_cast in KoPAOdfSaveHelper constructor
"Thomas Zander" <[email protected]> Tue, 13 Mar 2012 19:12:35 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============1486802789060580279==
Content-Type: multipart/alternative;
boundary="===============1191055317064985232=="
--===============1191055317064985232==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104263/#review11369
-----------------------------------------------------------
Ship it!
The change looks correct. =
The change made by me some time ago (2nd christmas day 2011) where there us=
ed to be a KoPAPageBase seems to me a likely cause of this bug, apologies f=
or not finding the unit test regression, and thanks for the fix!
- Thomas Zander
On March 13, 2012, 6:59 p.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104263/
> -----------------------------------------------------------
> =
> (Updated March 13, 2012, 6:59 p.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Description
> -------
> =
> The TestPACopyPastePage unit test was failing with a segmentation fault (=
signal 11). Debugging it in gdb showed that the cause was a null pointer f=
or the "page" variable in a loop through the master pages. Tracing this ba=
ck, I discovered some odd code that seemed to be dynamic_casting a Page* to=
a Page*. I'm not sure that behaviour is even defined in the C++ standard,=
but I'm pretty sure what we really want to do is cast to a MasterPage inst=
ead (and reverse the logic of the if statement). So that's what this patch=
does. =
> =
> =
> Diffs
> -----
> =
> libs/kopageapp/KoPAOdfPageSaveHelper.cpp 1a8f965 =
> =
> Diff: http://git.reviewboard.kde.org/r/104263/diff/
> =
> =
> Testing
> -------
> =
> Code still compiles and runs and master pages work. The TestPACopyPasteP=
age unit test now passes instead of failing and all other unit tests still =
pass (except the two that were failing already -- both related to layout pr=
oblems).
> =
> =
> Thanks,
> =
> Robert Mathias Marmorstein
> =
>
--===============1191055317064985232==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/104263/">http://git.revie=
wboard.kde.org/r/104263/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change=
looks correct. =
The change made by me some time ago (2nd christmas day 2011) where there us=
ed to be a KoPAPageBase seems to me a likely cause of this bug, apologies f=
or not finding the unit test regression, and thanks for the fix!</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 13th, 2012, 6:59 p.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style=3D"color: grey;"><i>Updated March 13, 2012, 6:59 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">The TestPACopyPastePage unit test was failing with a segment=
ation fault (signal 11). Debugging it in gdb showed that the cause was a n=
ull pointer for the "page" variable in a loop through the master =
pages. Tracing this back, I discovered some odd code that seemed to be dyn=
amic_casting a Page* to a Page*. I'm not sure that behaviour is even d=
efined in the C++ standard, but I'm pretty sure what we really want to =
do is cast to a MasterPage instead (and reverse the logic of the if stateme=
nt). So that's what this patch does. </pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Code still compiles and runs and master pages work. The Tes=
tPACopyPastePage unit test now passes instead of failing and all other unit=
tests still pass (except the two that were failing already -- both related=
to layout problems).</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPAOdfPageSaveHelper.cpp <span style=3D"color: grey">(=
1a8f965)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/104263/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1191055317064985232==--
--===============1486802789060580279==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
--===============1486802789060580279==--