Re: Review Request: Add parentheses around instatiation of object to avoid ambiguity
"Thomas Zander" <[email protected]> Tue, 13 Mar 2012 19:14:18 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============6103176929298527812==
Content-Type: multipart/alternative;
boundary="===============1245493144104040520=="
--===============1245493144104040520==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104262/#review11370
-----------------------------------------------------------
Ship it!
Can't imagine that having any negative side effects, so if it fixes the pro=
blem, then ship it :)
- Thomas Zander
On March 13, 2012, 6:53 p.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104262/
> -----------------------------------------------------------
> =
> (Updated March 13, 2012, 6:53 p.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Description
> -------
> =
> The clang compiler won't build the unit test without these parentheses cl=
aiming that it doesn't know how to disambiguate a function call. I'm not s=
ure I understand exactly why, but adding the parens fixes things so that th=
e unit test can build and doesn't have any other negative effect.
> =
> =
> Diffs
> -----
> =
> kcells/tests/TestLogicFunctions.cpp d49aeda =
> =
> Diff: http://git.reviewboard.kde.org/r/104262/diff/
> =
> =
> Testing
> -------
> =
> Compiled and ran unit tests with both gcc and clang. All tests still pas=
s (now with both compilers).
> =
> =
> Thanks,
> =
> Robert Mathias Marmorstein
> =
>
--===============1245493144104040520==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/104262/">http://git.revie=
wboard.kde.org/r/104262/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can't =
imagine that having any negative side effects, so if it fixes the problem, =
then ship it :)</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 13th, 2012, 6:53 p.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style=3D"color: grey;"><i>Updated March 13, 2012, 6:53 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">The clang compiler won't build the unit test without the=
se parentheses claiming that it doesn't know how to disambiguate a func=
tion call. I'm not sure I understand exactly why, but adding the paren=
s fixes things so that the unit test can build and doesn't have any oth=
er negative effect.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Compiled and ran unit tests with both gcc and clang. All te=
sts still pass (now with both compilers).</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>kcells/tests/TestLogicFunctions.cpp <span style=3D"color: grey">(d49ae=
da)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/104262/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1245493144104040520==--
--===============6103176929298527812==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
--===============6103176929298527812==--