Re: Review Request 124227: Remove Q3ListViews from autoreplace

> On July 15, 2015, 10:16 a.m., Laurent Montel wrote:
> > plugins/autoreplace/autoreplacepreferences.cpp, line 50
> > <https://git.reviewboard.kde.org/r/124227/diff/1/?file=385404#file385404line50>
> >
> >     Why ? 
> >     Why not add directly setColumCount(2) ?

Isn't it better not to hardcode ?


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review82520
-----------------------------------------------------------


On July 14, 2015, 11:58 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124227/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 11:58 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace the Q3ListView classes with QTreeWidgets.
> 
> 
> Diffs
> -----
> 
>   plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db 
>   plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 
> 
> Diff: https://git.reviewboard.kde.org/r/124227/diff/
> 
> 
> Testing
> -------
> 
> Build Succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel