Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124181/#review90332
-----------------------------------------------------------



protocols/groupwise/gwconnector.cpp (line 35)
<https://git.reviewboard.kde.org/r/124181/#comment61806>

    No need to change these two lines. Whitespaces must not be just inside SIGNAL/SLOT macros.



protocols/groupwise/ui/gwprivacydialog.cpp (line 160)
<https://git.reviewboard.kde.org/r/124181/#comment61807>

    I'm not sure this code is correct. You are iterating over indexes of allowList in for loop, but inside you are modifing indexes (with takeItem).



protocols/groupwise/ui/gwprivacydialog.cpp (line 176)
<https://git.reviewboard.kde.org/r/124181/#comment61808>

    Same as for allowList


- Pali Rohár


On sep. 2, 2015, 9:29 popoludní, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124181/
> -----------------------------------------------------------
> 
> (Updated sep. 2, 2015, 9:29 popoludní)
> 
> 
> Review request for Kopete and Laurent Montel.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Remove the K3ListBox and needless includes from groupwise.
> 
> 
> Diffs
> -----
> 
>   protocols/groupwise/gwconnector.cpp d1330ad824dc7c731dc37a95b8735273c4890a46 
>   protocols/groupwise/ui/gwchatprops.ui f93fb5db8269323d5b28bd60181bbe3a209f80e3 
>   protocols/groupwise/ui/gwchatpropsdialog.cpp 5226bb3959439e0c954c7416c10ce839988f8d2e 
>   protocols/groupwise/ui/gwprivacy.ui 34fc4e41a669994d90e0fd2de218367d4e2917ea 
>   protocols/groupwise/ui/gwprivacydialog.h 595a031de6383ea27e9b2d54e270044b4e715cf2 
>   protocols/groupwise/ui/gwprivacydialog.cpp 3b2210f6907d29931de50e27f299fa67b6c7fdc6 
> 
> Diff: https://git.reviewboard.kde.org/r/124181/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel