Re: Review Request 124227: Remove Q3ListViews from autoreplace

Pali Rohár <[email protected]>
Newsgroups gmane.comp.kde.devel.kopete
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review90335
-----------------------------------------------------------



plugins/autoreplace/autoreplacepreferences.cpp (line 91)
<https://git.reviewboard.kde.org/r/124227/#comment61810>

    move it into for loop where it is used



plugins/autoreplace/autoreplacepreferences.cpp (line 214)
<https://git.reviewboard.kde.org/r/124227/#comment61809>

    this varianle is used only in for loop, so move it there


- Pali Rohár


On sep. 2, 2015, 8 dopoludnia, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124227/
> -----------------------------------------------------------
> 
> (Updated sep. 2, 2015, 8 dopoludnia)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace the Q3ListView classes with QTreeWidgets.
> 
> 
> Diffs
> -----
> 
>   plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db 
>   plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 
> 
> Diff: https://git.reviewboard.kde.org/r/124227/diff/
> 
> 
> Testing
> -------
> 
> Build Succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.