D14685: [effects/sheet] Modernize code

anthonyfieroni added inline comments.

INLINE COMMENTS

> sheet.h:73-81
> +inline int SheetEffect::requestedEffectChainPosition() const
>  {
> -public:
> -    WindowInfo();
> -    ~WindowInfo();
> -    bool deleted;
> -    bool added;
> -    bool closed;
> -    QTimeLine *timeLine;
> -    int parentY;
> -};
> +    return 60;
> +}
> +
> +inline int SheetEffect::duration() const
> +{

I think, it's not mandatory, but since you change code style, does it better for function implementation to go in cpp files only.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14685

To: zzag, #kwin
Cc: anthonyfieroni, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart