D14685: [effects/sheet] Modernize code
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > anthonyfieroni wrote in sheet.h:73-81 > I think, it's not mandatory, but since you change code style, does it better for function implementation to go in cpp files only. AFAIK, all effects implement getters for properties in header files. So, I don't want this effect to deviate from the rest. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14685 To: zzag, #kwin Cc: anthonyfieroni, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart