D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects

Vlad Zagorodniy <[email protected]> Wed, 8 Aug 2018 12:51:41 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in fullScreenEffectTest.js:5
> Sure for production code, but the goal here is to test the public API.
> 
> I've added a second test with the unboxing version and I've added a comment here.

Looks like the second test can't be located:

  testdata ./scripts/fullScreenEffectTestMulti.js could not be located!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14688

To: davidedmundson, #kwin
Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart