D14685: [effects/sheet] Modernize code
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in sheet.h:26 > Not that I mind, but you just made a whole commit about pointless comments... I think that's fine in this case. It would tell people where to put includes. E.g. sometimes I see the following pattern Qt includes KF includes Qt includes //FWIW, in most cases, those includes are not sorted so there is a chance of adding duplicate includes// Also, most of KWin codebase does the same(adds include comments). REPOSITORY R108 KWin BRANCH rewrite-sheet-effect REVISION DETAIL https://phabricator.kde.org/D14685 To: zzag, #kwin, davidedmundson Cc: davidedmundson, anthonyfieroni, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart