D14728: [effects/minimizeanimation] Delete useless comments
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in minimizeanimation.h:30 > Being explicit that this also handles unminimise does add value. > > IMHO all of them could benefit from a one liner here saying what the effect is actually meant to do. Hmm, yeah, you're right. (I deleted this comment because of MinimizeAnimationEffect name). Also, maybe, it would be worth to add such comments to other effects. For example, it would be great to describe what algorithm the blur effect uses. I'll revert this particular change. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14728 To: zzag, #kwin Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart