D13461: [effects] Add Scale effect
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in scale.cpp:260 > Ok, I don't really like this given we control plasma, we shouldn't need be hardcoding blacklists and having heuristics. > > But the login windows are already blacklisted in other effects. That can be a task for another day. As I said in the glide effect diff, I also don't like it. For now, that's somewhat ok solution, but I agree, we need to fix it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D13461 To: zzag, #kwin, #plasma, #vdg, davidedmundson Cc: ngraham, davidedmundson, fvogt, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart