D14862: [effects/slidingpopups] Overhaul slotPropertyNotify

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in slidingpopups.cpp:319
> what's the rationale behind this cap value?

If I understand your question correctly, you ask why we don't allow to use "0" as a duration?

TimeLine will later divide the number number of elapsed milliseconds by this duration (d->elapsed / d->duration), so we have to prevent division by 0.

Also, maybe, in this case, we could do something similar to what we do in reconfigure(), e.g.

  animData.slideInDuration = (animData.slideInDuration().count() != 0)
      ? animData.slideInDuration
      : m_slideInDuration;

REPOSITORY
  R108 KWin

BRANCH
  effects-slidingpopups-validate-data-size

REVISION DETAIL
  https://phabricator.kde.org/D14862

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart