D14862: [effects/slidingpopups] Overhaul slotPropertyNotify
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > slidingpopups.cpp:319 > + animData.slideInDuration = std::chrono::milliseconds( > + qMax(animData.slideInDuration.count(), 1l)); > + what's the rationale behind this cap value? REPOSITORY R108 KWin BRANCH effects-slidingpopups-validate-data-size REVISION DETAIL https://phabricator.kde.org/D14862 To: zzag, #kwin, davidedmundson Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart