D13720: [effects] Rewrite the Dim Inactive effect

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> diminactive.cpp:104-105
> +
> +    auto transitionIt = m_transitions.begin();
> +    while (transitionIt != m_transitions.end()) {
> +        (*transitionIt).update(delta);

constBegin/constEnd

> diminactive.cpp:240
> +    TimeLine &timeLine = m_transitions[w];
> +    timeLine.reset();
> +    timeLine.setDuration(

why the reset?

won't that flicker if you

inactive -> active -> inactive

really really quickly.

REPOSITORY
  R108 KWin

BRANCH
  rewrite-diminactive-effect

REVISION DETAIL
  https://phabricator.kde.org/D13720

To: zzag, #kwin, #plasma, #vdg, davidedmundson
Cc: davidedmundson, abetts, ngraham, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart