D13720: [effects] Rewrite the Dim Inactive effect

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in diminactive.cpp:104-105
> constBegin/constEnd

It won't be compiled:

`(*transitionIt)` would return `const T &`, where `T = TimeLine`. It would work with pointers because what iterator returns is a const reference to a pointer, e.g.

  const (TimeLine *) &

> davidedmundson wrote in diminactive.cpp:240
> why the reset?
> 
> won't that flicker if you
> 
> inactive -> active -> inactive
> 
> really really quickly.

Good question. The In and the Out animations are different so that's fine to reset them.

> really really quickly

It will be noticeable only when animation time factor is 4x+.

On the other hand, TimeLine tries its best to smooth "transition" from old duration to new duration. The problem is when we're truncating duration(e.g. 250ms -> 160ms). But that's easy to fix:

  timeLine.setDuration(smallerDuration);
  if (timeLine.done()) {
      timeLine.reset();
  }

I'll change it.

REPOSITORY
  R108 KWin

BRANCH
  rewrite-diminactive-effect

REVISION DETAIL
  https://phabricator.kde.org/D13720

To: zzag, #kwin, #plasma, #vdg, davidedmundson
Cc: davidedmundson, abetts, ngraham, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart