D14783: [scenes/opengl] Correctly draw shadows when corner tiles are missing

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added a comment.


  Maybe, it makes more sense to squash D14783 <https://phabricator.kde.org/D14783> and D14784 <https://phabricator.kde.org/D14784>.

INLINE COMMENTS

> davidedmundson wrote in scene_opengl.cpp:2337
> D14784 <https://phabricator.kde.org/D14784> has the line
> 
> p.drawPixmap(width - topRight.width(), 0, shadowPixmap(ShadowElementTopRight));

It draws the top-right tile in the top-right corner of the texture atlas.

For example, take a look at this texture atlas, here's bottom tile is wider than top tile.

F6208389: P80821-215857.jpg <https://phabricator.kde.org/F6208389>

//sorry for quick & dirty drawing//

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14783

To: zzag, #kwin
Cc: abetts, davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.