D15175: [effects/cubeslide/wayland] Fix several cubeslide issues

poboiko added a comment.


  I don't use arcanist for commits, so I planned to add those keywords by hand afterwards.

INLINE COMMENTS

> zzag wrote in cubeslide.cpp:188-194
> I think we should force roles at the beginning of the animation. And reset them at the end of the animation.
> 
> We should keep the number of memory allocations at the minimum.

Yeah, I though about it. It's just I wanted to avoid code duplication, since animation starts in several different places (i.e. when desktop changes, but also when user moves window through the border). I guess I'll make another function which does it (and maybe other common stuff)

> zzag wrote in cubeslide.cpp:525-532
> No, that's wrong. During the cube slide animation windows are 3D transformed. Thus, that's wrong to blur background behind them.
> 
> We should force blur and background contrast only for sticky windows. Also, I think we don't need to keep track of window with forced roles. So, please delete m_forcedRoles.

I thought about it initially, but I found out that it actually works fine - it blurs background on the moving cube face for non-sticky windows.

Concerning m_forcedRoles - I added it so I can remove those roles afterwards. You're saying that I don't really have to do it?

> zzag wrote in cubeslide.cpp:543
> Hm, what about renaming it to `isStickyWindow`?

Well, it also includes panels, but I can change it (probably, that semantics is even more obvious due to the context).

> zzag wrote in cubeslide.cpp:548
> It would animate notifications, desktop switch OSD, etc. What about
> 
>   if (dontSlideStickyWindows && w->isOnAllDesktops()) {
>       if (w->isDesktop()) {
>           return true;
>       }
>       // other checks?
>       return false;
>   }
> 
> Keep in mind, that's just a hypothesis.

Oh. It actually might work, thanks! Will do the testing.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15175

To: poboiko, #kwin, zzag
Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart