D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Change FIXED-IN to 5.15.0

INLINE COMMENTS

> cubeslide.cpp:521-526
> +    if (!isActive() || shouldAnimate(w)) {
> +        return;
> +    }
> +    staticWindows.insert(w);
> +    w->setData(WindowForceBlurRole, QVariant(true));
> +    w->setData(WindowForceBackgroundContrastRole, QVariant(true));

Readability nitpick: isActive() and shouldAnimate check two different things. It would be better to have something like

  if (!isActive()) {
      return;
  }
  if (!shouldAnimate(w)) {
      ...
  }

> cubeslide.cpp:538
> +    }
> +    if (w->isOnAllDesktops()) {
> +        if (!w->isManaged()) {

We always have to animate desktop window.

  if (w->isDesktop()) {
      return true;
  }

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15175

To: poboiko, #kwin, zzag
Cc: davidedmundson, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart