D15496: [effects/cubeslide] Fix "sticky" windows detection on Wayland

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  > if (w->isSpecialWindow()) {
  
  and everything makes sense, that's a known wayland behavioural change. ++
  
  > // Apparently, acceptsFocus() is the only way how OSD differs from ordinary window on Wayland
  
  This is working round KDE code. We shouldn't be doing that. I'm happy to help fix as it'll be Plasma::Dialog at fault.
  
  I've applied this patch and removed that line, and can't see what's wrong? 
  I switch desktop, the OSD remains in the middle. Any notification dialogs stay where they should.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15496

To: poboiko, #kwin, davidedmundson
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart