D15372: [effects] Make scripted effects GHNS-able

davidedmundson added a comment.


  It's a bit weird to use kpackage here but not in ScriptedEffect itself but we can deal with that later.
  
  I have a vague recollection of this previously being blocked on the grounds of "security" but I can't see it in my logs anywhere.

INLINE COMMENTS

> model.cpp:30
>  #include <KService>
>  #include <KServiceTypeTrader>
>  #include <KSharedConfig>

can we drop these?

> effect.cpp:34
> +    package->addDirectoryDefinition("code", QStringLiteral("code"), i18n("Executable Scripts"));
> +    package->addDirectoryDefinition("config", QStringLiteral("config"), i18n("Configuration Definitions"));
> +    package->addDirectoryDefinition("ui", QStringLiteral("ui"), i18n("User Interface"));

The exact file path is hardcoded as config/main.qml, at which point we should add a fileDefintion for that instead

> effect.cpp:41
> +    package->setMimeTypes("config", {QStringLiteral("text/xml")});
> +    package->setMimeTypes("effect", {QStringLiteral("text/plain")});
> +}

Where is effect defined?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15372

To: zzag, #kwin, mart
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart