D15372: [effects] Make scripted effects GHNS-able

Vlad Zagorodniy <[email protected]> Mon, 17 Sep 2018 14:05:26 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added a comment.


  In D15372#327588 <https://phabricator.kde.org/D15372#327588>, @davidedmundson wrote:
  
  > It's a bit weird to use kpackage here but not in ScriptedEffect itself but we can deal with that later.
  
  
  ScriptedEffectLoader also uses KPackage.

INLINE COMMENTS

> davidedmundson wrote in effect.cpp:41
> Where is effect defined?

Copy-paste.

I also wonder why other package structure plugins do the same. Can we drop it?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15372

To: zzag, #kwin, mart
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart