D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects

zzag added a comment.


  I like this one more.
  
  As an alternative approach we could have the tristate and current signals, e.g.
  
    effects.activeFullScreenChanged.conect(function () {
        // effect.activeFullScreenState can have the following values:
        //    - Effect.InactiveFullScreenEffect
        //    - Effect.OwnedFullScreenEffect
        //    - Effect.ActiveFullScreenEffect
    });
    
    effect.activeFullScreenChanged.connect(function () {
        // effect.activeFullScreenState can have the following values:
        //    - Effect.InactiveFullScreenEffect
        //    - Effect.ActiveFullScreenEffect
    });
  
  This way is cleaner to me(we don't have to add a new property to EffectsHandler). (I really like your tristate approach)
  
  And of course, we would need to document the difference between those 2 signals.
  
  Cons: effect.activeFullScreenState is not intuitive, but that's fine.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14688

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart