D15735: [effects/wobblywindows] Optimize wobbly windows effect

anthonyfieroni added inline comments.

INLINE COMMENTS

> zzag wrote in wobblywindows.cpp:60-136
> This should go in another patch.

I don't see why, it's pretty safe and does not need go in another one, after all we waste a time since doing some work.

> zzag wrote in wobblywindows.cpp:712-714
> Can you please clarify why you deleted this one? Shouldn't we pass closeRect as rect in paintWindow, e.g.:
> 
>   const QRectF rect = wwi.status == Closing ? wwi.closeRect : w->geometry();
> 
> ?

It does not make sense to me, why we want to use closeRect?

> zzag wrote in wobblywindows.h:201-211
> Please leave them here. (Move them up in a patch that does code cleanup)

See above comment from @romangg

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15735

To: anthonyfieroni, #kwin, zzag
Cc: romangg, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart