D15735: [effects/wobblywindows] Optimize wobbly windows effect

zzag requested changes to this revision.
zzag added a comment.
This revision now requires changes to proceed.


  > Remove scene repaints which cause visual glitch (open window moves it to top right corner to became maximize, grab it for title and move it to restore it size)
  
  The Maximize effect causes that, not scene repaints. Please add the repaints back until we find proper solution.
  
  > I don't see why, it's pretty safe and does not need go in another one,
  
  Because that's unrelated change. If it should go in, then what does your patch try to address?
  
  > after all we waste a time since doing some work.
  
  This patch has unrelated changes and you're objecting to remove them. Instead of focusing on one particular change, it shuffles code around, it alters behavior(e.g. removal of repaints), and it does code cleanup.

INLINE COMMENTS

> wobblywindows.cpp:503
> +            windows.erase(it);
> +            w->unrefWindow();
>          }

That's not possible to have ref'ed window at this point.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15735

To: anthonyfieroni, #kwin, zzag
Cc: romangg, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart