D14919: [effects/dialogparent] Fix flickering of parent windows

davidedmundson added inline comments.

INLINE COMMENTS

> kwinanimationeffect.cpp:291
>                  entry->first.erase(anim); // remove the animation
>                  if (entry->first.isEmpty()) { // no other animations on the window, release it.
>                      const int i = d->m_zombies.indexOf(entry.key());

If I have two animations active and only one is keep alive, if I cancel the keep alive one should I unref the window?

> kwinanimationeffect.cpp:389
>      // janitorial...
>      if (d->m_animations.isEmpty()) {
>          disconnectGeometryChanges();

and here

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14919

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart