D14919: [effects/dialogparent] Fix flickering of parent windows

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kwinanimationeffect.cpp:291
> If I have two animations active and only one is keep alive, if I cancel the keep alive one should I unref the window?

Yes, we should unref window. I was thinking about implementing something similar to FullScreenEffectLock, e.g.

  class KeepAliveLock
  {
  public:
      KeepAliveLock(EffectWindow *w) { w->refWindow(); }
      ~KeepAliveLock() { w->unrefWindow(); }
      ...
  };

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14919

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart