D16372: [effects] Re-implement the Minimize Animation effect in JavaScript

davidedmundson added a comment.


  cool stuff

INLINE COMMENTS

> minimizeanimation.h:49
> -    int requestedEffectChainPosition() const override {
> -        return 50;
> -    }

You've changed this to 60. Is that deliberate?

> main.js:97
> +
> +        if (window.minimizeAnimation) {
> +            // TODO: Try to reverse it instead.

We're not deleting the property if the animation ends normally.

Won't cause any real problem right now, but it might cause a problem when we sort out the TODO.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16372

To: zzag, #kwin, #plasma
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart