D16372: [effects] Re-implement the Minimize Animation effect in JavaScript
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in minimizeanimation.h:49 > You've changed this to 60. Is that deliberate? Most scripted effects use 60 for some reason. So does this effect. I change to 50 if that's an issue. > davidedmundson wrote in main.js:97 > We're not deleting the property if the animation ends normally. > > Won't cause any real problem right now, but it might cause a problem when we sort out the TODO. I don't think that would the problem. If the animation has finished, function that reverses animations should return false, indicating that it couldn't reverse the animation. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16372 To: zzag, #kwin, #plasma Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart