D16372: [effects] Re-implement the Minimize Animation effect in JavaScript

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Most scripted effects use 60 for some reason.
  
  Most effects that are chained in the middle don't really matter.
  
  I wanted to point out there was a difference, up to you which you do.

INLINE COMMENTS

> zzag wrote in main.js:97
> I don't think that would the problem. If the animation has finished, function that reverses animations should return false, indicating that it couldn't reverse the animation.

Sure one could guard it, but the intuitive thing is to write:

  if (window.minimizeAnimation) {
    reverse(window.minimizeAnimation);
    return;
  }

And then waste several hours.

But it'll be you doing that change, so we can handle it then.

REPOSITORY
  R108 KWin

BRANCH
  zzag/port-minimizeanimation-to-javascript

REVISION DETAIL
  https://phabricator.kde.org/D16372

To: zzag, #kwin, #plasma, davidedmundson
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart