D16602: [libkwineffects] Replace property name lookup with calling the virtual methods
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added a comment. Oh, I didn't think to look. It is possible to do something with just one string lookup of the object type and then keep a hash if we desperately want to keep it. Though we've failed to keep ABI for practically every release in the 5.x series even with this. I think /if/ ABI compatibility is a worthwhile goal we should be using pimpl and having EffectWindowImpl subclass EffectWindow::Private which contains the virtuals - but that would be a task for another day. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16602 To: davidedmundson, #kwin Cc: zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart