D16602: [libkwineffects] Replace property name lookup with calling the virtual methods

zzag added a comment.


  In D16602#352699 <https://phabricator.kde.org/D16602#352699>, @davidedmundson wrote:
  
  > Though we've failed to keep ABI for practically every release in the 5.x series even with this.  I think /if/ ABI compatibility is a worthwhile goal we should be using pimpl and having EffectWindowImpl subclass EffectWindow::Private which contains the virtuals - but that would be a task for another day.
  
  
  Yeah, it would be great to do that way.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16602

To: davidedmundson, #kwin
Cc: zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart