D16602: [libkwineffects] Replace property name lookup with calling the virtual methods
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added a comment. Some notes: when we introduced the property solution we assumed it's not more expensive than the virtual lookup. When we introduced it we were still adding lots of new methods to the API. Furthermore we did not increase the so version and instead used internal api versioning. Distros were complaining a lot about the situation. At that time we expected that 3rd party binary effects would be added. Today we do want 3rd party to use scripting, we do so versioning and effectwindow doesn't change that often. So in summary: go for it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16602 To: davidedmundson, #kwin Cc: graesslin, zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart