D16602: [libkwineffects] Replace property name lookup with calling the virtual methods

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Please do not add the methods to Toplevel. This would break the semantics of this class hierarchy. The idea of Toplevel is being the base of a managed and an unmanaged window. Having methods in Toplevel which don't fit the semantics of an unmanaged window is problematic. An unmanaged cannot be keepBeliw and it's caption cannot change as it doesn't have one. I would prefer if the API stays clean to express these differences (that's btw. the reason for introducing AbstractClient).
  
  The code before the introduction of the properties used dynamic casts to figure out whether it's an unmanaged or client and called the appropriate methods. I'm sure there's a neat trick allowing to keep the semantics and not needing additional performance.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16602

To: davidedmundson, #kwin, graesslin
Cc: graesslin, zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart