D16452: [effects/dimscreen] Port to JavaScript

davidedmundson added inline comments.

INLINE COMMENTS

> main.js:50
> +    duration: animationTime(250),
> +    saturation: 0.77,
> +    brightness: 0.77,

This used to be:

data.multiplyBrightness((1.0 - 0.33 * timeline.currentValue()));

so this should be ~0.67?

> main.js:67
> +        if (window.dimAnimation) {
> +            if (redirect(window.dimAnimation, Effect.Forward)) {
> +                return;

I'd rather we cleaned the animation ID when it ends rather than leaving dangling IDs everywhere and having to work round it - but I won't insist on it if you disagree.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16452

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart