D16452: [effects/dimscreen] Port to JavaScript

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.js:50
> This used to be:
> 
> data.multiplyBrightness((1.0 - 0.33 * timeline.currentValue()));
> 
> so this should be ~0.67?

Oh my God, this is so embarrassing. Yes, it should be 0.67.

> davidedmundson wrote in main.js:67
> I'd rather we cleaned the animation ID when it ends rather than leaving dangling IDs everywhere and having to work round it - but I won't insist on it if you disagree.

> ... cleaned the animation ID when it ends rather than leaving dangling IDs

Makes sense.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16452

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart