D16802: effects: attempt to screenshot on OpenGL ES 2.0 instead of failing

bshah added a comment.


  > The problem is that calls into OpenGL extensions can crash if it's not available. The proper behavior is to return a null pointer if an extension is missing. So the change you did here would crash on any driver not supporting blit and properly returning null for the blit functionality.
  
  No, the call won't ever reach OpenGL extnesion,
  
    1273 void GLRenderTarget::blitFromFramebuffer(const QRect &source, const QRect &destination, GLenum filter)                                                                  
    1274 {
    1275     if (!GLRenderTarget::blitSupported()) {
    1276         return;
    1277     }
    1278 
  
  This is current code in kwinglutils.cpp, so `target.blitFromFramebuffer` call is just no-op if blit is not supported.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16802

To: bshah, #kwin, davidedmundson, graesslin
Cc: graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart