D16802: effects: attempt to screenshot on OpenGL ES 2.0 instead of failing
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added a comment. In D16802#357617 <https://phabricator.kde.org/D16802#357617>, @bshah wrote: > > glReadPixels is slow. That's not a general solution and I would recommend against using it. It's better to not do a screenshot than screenshot with glReadPixels. > > Well, we are dong that already.. this code is confusing.. see Line 561+. ah the complete code block looks wrong. There is no glGetTexImage support in OpenGL ES, so that's why glReadPixels is used. On the other hand the complete blitting doesn't make sense if we use glReadPixels. So the code needs to be reworked to if (blit && !gles) else glReadPixels REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16802 To: bshah, #kwin, davidedmundson, graesslin Cc: graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart