D16835: Don't cache value of popupWindow property in EffectWindow

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  With the plasma shell protocol, a ShellClient gets its role/window type
  after it's created, so the cached value of the popupWindow property in
  EffectWindow can be wrong.
  
  In addition to that, the value of the popupWindow property still can be
  wrong because plasma shell surfaces don't have xdg-popup role, so we need
  to check NetWM-based window type in ShellClient::isPopupWindow.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16835

AFFECTED FILES
  deleted.cpp
  deleted.h
  libkwineffects/kwineffects.cpp
  shell_client.cpp

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart