D16836: [effects] Split the Fade effect

zzag created this revision.
zzag added reviewers: KWin, Plasma.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Currently, we have three effects that can be used to animate the
  appearing of toplevel windows(fade, glide, scale) and one can enable
  all three of them, which seems to be wrong. It doesn't make sense to have
  glide and scale effect enabled, for example.
  
  We couldn't put all three effects into an exclusive group before because
  the fade effect animates not only toplevel windows but also popups. So,
  if all three effects are in an exclusive group and you enable glide effect,
  for example, then tooltips and other popups won't be faded in/out.
  
  This patch splits the fade effect into two: the first effect (called Fade)
  animates toplevel windows and the other one (called Fading Popups) animates
  popup windows, making it possible to put fade, scale, and glide effect
  into an exclusive group.

TEST PLAN
  Have been using this effect for a couple of days, didn't notice any
  significant differences.

REPOSITORY
  R108 KWin

BRANCH
  split-fade-effect

REVISION DETAIL
  https://phabricator.kde.org/D16836

AFFECTED FILES
  autotests/test_plugin_effectloader.cpp
  autotests/test_scripted_effectloader.cpp
  effects/CMakeLists.txt
  effects/fade/package/contents/code/main.js
  effects/fadingpopups/CMakeLists.txt
  effects/fadingpopups/package/CMakeLists.txt
  effects/fadingpopups/package/contents/code/main.js
  effects/fadingpopups/package/metadata.desktop

To: zzag, #kwin, #plasma
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart