D16449: [scripting] Introduce redirect function

davidedmundson added a comment.


  Generally, ship it!

INLINE COMMENTS

> anidata_p.h:101
>      PreviousWindowPixmapLockPtr previousWindowPixmapLock;
> +    AnimationEffect::TerminationPolicy terminationPolicy = AnimationEffect::TerminateAtSource;
>  };

Would it be feasible to have matching names and types for keepAtTarget and keepAtSource. They're effectively doing the same thing

> kwinanimationeffect.cpp:346
> +
> +        default:
> +            Q_UNREACHABLE();

It's better to not specify a default for a finite list.

This way you get a compile warning if someone added a 3rd direction.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16449

To: zzag, #kwin
Cc: davidedmundson, abetts, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart