D16449: [scripting] Introduce redirect function

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in anidata_p.h:101
> Would it be feasible to have matching names and types for keepAtTarget and keepAtSource. They're effectively doing the same thing

So, instead of having two booleans, we would have a single enum, right?
Yeah, it makes sense, but this would be unrelated to this change.

> davidedmundson wrote in kwinanimationeffect.cpp:346
> It's better to not specify a default for a finite list.
> 
> This way you get a compile warning if someone added a 3rd direction.

I did this deliberately because one can go either forward or backward, but I don't insist on this one. Should I delete this part of code?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16449

To: zzag, #kwin
Cc: davidedmundson, abetts, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.