D16932: Delete kglobalshortcutsrc before executing a test
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin created this revision. graesslin added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. graesslin requested review of this revision. REVISION SUMMARY When running the complete test suite the ScriptedEffectsTest::testShortcuts registers the shortcut meta+shift+y. But GlobalShortcutsTest::testX11ClientShortcut also tries to use this shortcut for a window shortcut which fails if it is already registered. So when running the complete test suite it depends on the order of execution whether the GlobalShortcutsTest passes or not. Test should be clean - also the globalshortcuts. As the config is read from test directory anyway, we can delete the file prior to init of kglobalaccel. TEST PLAN Run ctest, test did not fail anymore REPOSITORY R108 KWin BRANCH delete-kglobalshortcutsrc-tests REVISION DETAIL https://phabricator.kde.org/D16932 AFFECTED FILES autotests/integration/kwin_wayland_test.cpp To: graesslin, #kwin Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart