D17544: virtualkeyboard: report the size of the inputwindow

graesslin added a comment.


  In D17544#376110 <https://phabricator.kde.org/D17544#376110>, @bshah wrote:
  
  > I also realized that I am passing this wrong information, I am passing it just keyboard position, which is not what client is interested in if I understand it correctly.
  
  
  Yeah, as the comment says it's about the overlap. Which is not totally trivial, otherwise I would have added it instead of a todo :-P Basically we need to calculate the overlap of the client in screen geometry with the input window in screen geometry and transfer this overlap (if there is any) to client coordinates. To make it worse this needs to also handle window decoration which is something the client doesn't know about. Oh and of course the scaling of the surface needs to be considered.
  
  I know we don't have tests yet for the virtual keyboard, but this is a functionality I wouldn't dare to add without having some good test cases at hand. Especially for such situations as virtual keyboard on one screen, application on other screen, overlap, no overlap, deco, scaling, etc.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17544

To: bshah, #plasma, #kwin
Cc: graesslin, davidedmundson, kwin, mart, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol