D17546: Remove no longer needed cast to Client in Workspace::sendClientToDesktop
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added inline comments. INLINE COMMENTS > zzag wrote in shell_client_test.cpp:1124 > Wouldn't it be better to check against VirtualDesktop? yes and no. I decided to use the old X11 numbering here as the slotWindowToDesktop method which I want to test takes the X11 number and not a VirtualDesktop. So for readability of the test I thought it's better to use the desktop numbers. But yes, in general using the more modern API would be better and it's something I thought about when writing the test case. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D17546 To: graesslin, #kwin Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart