D17265: Ensure consistency when the layout is changed via the dbus protocol

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I have problems following what this change does. All of it has nothing to do with the title. Could you please split this into three commits and reviews for each of the addressed points.
  
  Please also extend the existing virtual desktop manager test for the new changes you are doing.

INLINE COMMENTS

> virtualdesktops.cpp:482
>      m_desktops.insert(actualNumber - 1, vd);
> +
>      save();

Unrelated empty line

> virtualdesktops.cpp:715
>          QString s = group.readEntry(QStringLiteral("Name_%1").arg(i), i18n("Desktop %1", i));
> +
>          if (m_rootInfo) {

Unrelated empty line

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17265

To: mart, #plasma, #kwin, hein, davidedmundson, graesslin
Cc: graesslin, davidedmundson, ngraham, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart