D17265: Ensure consistency when the layout is changed via the dbus protocol

Marco Martin <[email protected]> Thu, 20 Dec 2018 17:26:05 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

mart added a comment.


  In D17265#380034 <https://phabricator.kde.org/D17265#380034>, @graesslin wrote:
  
  > I have problems following what this change does. All of it has nothing to do with the title. Could you please split this into three commits and reviews for each of the addressed points.
  
  
  well, the thing the patch does is really one, making setting rows work when done via the dbus protocol, i don't think is really splittable
  
  > Please also extend the existing virtual desktop manager test for the new changes you are doing.
  
  the last  changes in the review were mostly to make existing tests work again tough
  one test that may be useful to add is how rows() changes by changing the count

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17265

To: mart, #plasma, #kwin, hein, davidedmundson, graesslin
Cc: graesslin, davidedmundson, ngraham, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart