D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  >>! In D18458#398298 <https://phabricator.kde.org/D18458#398298>, @broulik wrote:
  
  > I must say, very tasteful "Buttons" page! :)
  
  Thanks!
  
  > I think the Theme grid should use the same `GridView` stuff we use in other KCMs, to provide a unified look, perhaps with a bigger grid size to accomodate for the increased complexity of the preview.
  
  Done. And it does look better and cleaner with the extra spacing!
  
  > And yes, please add some screenshots for VDG
  
  Here's a few shots - sorry, I keep forgetting to do this.
  https://imgur.com/a/mN8TVKP

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:50
> SimpleKCM expects there to be a central flickable Item
> 
> See the base class Kirigami.ScrollablePage
> 
> Given our main central item is the tabview we might be best off inheriting from Kirigami.Page

Setting a couple properties for the Page's `flickable` item seems to fix the issue, but I fear it's not enough: look at the last image of this gallery
https://imgur.com/a/mN8TVKP
There's an issue with it being painted over the borders.

> davidedmundson wrote in kcm.cpp:145
> Can I check this FIXME is just a new idea and not a regression?

It is a regression, the older KCM collected from plugins one "KNewStuff" field, and added it to the categories. This seems not to be possible anymore because

1. The KHNS api doesn't allow expanding whatever categories.
2. Some plugins (most notably, Breeze) don't have this field at all.

I'll just take it away for now. I'd just like a confirmation that the categories I chose for the .knsrc file are correct/acceptable.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart