D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo updated this revision to Diff 50150.
vpilo marked 5 inline comments as done.
vpilo added a comment.


  - Review changes
    - Fixed default button.
    - Changed `main.qml` to properly user the `KCM.SimpleKCM` root item.
    - Changed `Themes.qml` to a single `KCM.GridView` with better spacing.
    - Removed FIXMEs added for feedback.
  
      Additional changes/improvements:
    - Fixed a couple issues with pressing the defaults button.
    - Added live update of themes when the system color scheme or a theme's settings change.
    - Fixed wrong service type in `metadata.desktop`.
    - Fixed providers URL in `window-decorations.knsrc`.
    - Fix alignment of Configure Theme buttons when the theme has shadows.
    - Removed apply button in `previewbridge.cpp`: After applying changes, the theme's `KCModule` is somehow not valid any more and changing more options does nothing (it can also cause a crash). Maybe good for a separate discussion?

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18458?vs=50075&id=50150

BRANCH
  vpilo/deco_rewrite

REVISION DETAIL
  https://phabricator.kde.org/D18458

AFFECTED FILES
  kcmkwin/kwindecoration/CMakeLists.txt
  kcmkwin/kwindecoration/Messages.sh
  kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp
  kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.h
  kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewbutton.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp
  kcmkwin/kwindecoration/decorationmodel.cpp
  kcmkwin/kwindecoration/decorationmodel.h
  kcmkwin/kwindecoration/kcm.cpp
  kcmkwin/kwindecoration/kcm.h
  kcmkwin/kwindecoration/kcm.ui
  kcmkwin/kwindecoration/kwindecoration.desktop
  kcmkwin/kwindecoration/package/contents/ui/ButtonGroup.qml
  kcmkwin/kwindecoration/package/contents/ui/Buttons.qml
  kcmkwin/kwindecoration/package/contents/ui/Options.qml
  kcmkwin/kwindecoration/package/contents/ui/Themes.qml
  kcmkwin/kwindecoration/package/contents/ui/main.qml
  kcmkwin/kwindecoration/package/metadata.desktop
  kcmkwin/kwindecoration/qml/ButtonGroup.qml
  kcmkwin/kwindecoration/qml/Buttons.qml
  kcmkwin/kwindecoration/qml/Previews.qml
  kcmkwin/kwindecoration/qml/main.qml
  kcmkwin/kwindecoration/utils.cpp
  kcmkwin/kwindecoration/utils.h
  kcmkwin/kwindecoration/window-decorations.knsrc

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart